chore: add some basic instrumentation to Node WebSocket server #14354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious, what's the value of Prometheus over statsd here? The main superset app uses statsd for metrics and counters currently, so I wonder if we should use the same protocol for both apps |
|
@etr2460 there had been talks on the Preset side around moving to Prometheus given a couple of problems we ran into with statsd. @craig-rueda has more context on those. I agree that being consistent makes sense, so I think for now we can revert back to statsd. |
benjreinhart
force-pushed
the
benjreinhart/ws-statsd
branch
from
ea9abae
to
275c6b2
Compare
craig-rueda
approved these changes
Apr 26, 2021
|
Makes sense. If we want to switch, i think that seems SIP worthy. But would love to learn more about the issues you've been having! |
etr2460
approved these changes
Apr 26, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…e#14354) * chore: add some basic instrumentation * Switch to statsd using hot-shots * Cleanup a few leftover bits
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds some basic instrumentation to the node WebSocket server. For now, adding two counters:
TEST PLAN
Unit tests, manual