New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: SQL Statement on QUERY_LOGGER prints none to log #14358
fix: SQL Statement on QUERY_LOGGER prints none to log #14358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks so much for the fix!
Codecov Report
@@ Coverage Diff @@
## master #14358 +/- ##
==========================================
+ Coverage 79.78% 79.92% +0.14%
==========================================
Files 943 944 +1
Lines 47748 47999 +251
Branches 6026 6026
==========================================
+ Hits 38094 38363 +269
+ Misses 9533 9515 -18
Partials 121 121
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit f55882e)
(cherry picked from commit f55882e)
SUMMARY
Attempting to fix issue described here: #11356
TEST PLAN
As per issue linked above:
def log_sql_statements(database, query, schema, user, client, security_manager, log_params): logger.info("query is:" + str(query)) QUERY_LOGGER = log_sql_statements
ADDITIONAL INFORMATION