Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove panel from userinfo component #14364

Merged
merged 11 commits into from May 8, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Apr 27, 2021

SUMMARY

Remove panel

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screen.Recording.2021-04-29.at.5.38.18.PM.mov

after

Screen.Recording.2021-04-29.at.5.40.28.PM.mov

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #14364 (ed4dba0) into master (6871ad1) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14364      +/-   ##
==========================================
- Coverage   77.09%   77.09%   -0.01%     
==========================================
  Files         959      959              
  Lines       48309    48311       +2     
  Branches     5661     5662       +1     
==========================================
  Hits        37243    37243              
- Misses      10866    10868       +2     
  Partials      200      200              
Flag Coverage Δ
javascript 72.39% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/profile/components/App.tsx 85.71% <50.00%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6871ad1...ed4dba0. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.163.119.228:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 30, 2021
@junlincc
Copy link
Member

junlincc commented May 5, 2021

@pkdotson let's get the check pass.

@junlincc junlincc added the frontend:refactor Related to refactoring the frontend label May 5, 2021
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit cee22e2 into apache:master May 8, 2021
@rusackas rusackas deleted the userInfo-migration branch May 8, 2021 22:04
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* first pass

* fix merge

* fix lint

* covert pane to styled comp

* add theme

* fix lint

* fix test

* remove unused import
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* first pass

* fix merge

* fix lint

* covert pane to styled comp

* add theme

* fix lint

* fix test

* remove unused import
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* first pass

* fix merge

* fix lint

* covert pane to styled comp

* add theme

* fix lint

* fix test

* remove unused import
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels frontend:refactor Related to refactoring the frontend preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants