Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): fix lint #14387

Merged
merged 7 commits into from Apr 28, 2021
Merged

fix(native-filters): fix lint #14387

merged 7 commits into from Apr 28, 2021

Conversation

simcha90
Copy link
Contributor

SUMMARY

fix lint issues in dashboard

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@simcha90 simcha90 closed this Apr 28, 2021
@simcha90 simcha90 reopened this Apr 28, 2021
@simcha90 simcha90 changed the title lint(native-filters): fix lint fix(native-filters): fix lint Apr 28, 2021
@simcha90 simcha90 closed this Apr 28, 2021
@simcha90 simcha90 reopened this Apr 28, 2021
@villebro villebro merged commit fc0c115 into apache:master Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #14387 (dbb5e46) into master (2486fd4) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14387      +/-   ##
==========================================
- Coverage   76.79%   76.78%   -0.01%     
==========================================
  Files         955      955              
  Lines       48247    48255       +8     
  Branches     6030     6035       +5     
==========================================
+ Hits        37051    37055       +4     
- Misses      11001    11005       +4     
  Partials      195      195              
Flag Coverage Δ
javascript 71.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx 86.95% <0.00%> (-1.42%) ⬇️
superset-frontend/src/dashboard/actions/hydrate.js 3.30% <0.00%> (-0.06%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 90.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2486fd4...dbb5e46. Read the comment docs.

amitmiran137 pushed a commit that referenced this pull request Apr 28, 2021
* fix:fix get permission function

* lint: fix types

(cherry picked from commit fc0c115)
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label May 12, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix:fix get permission function

* lint: fix types
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard size/XS v1.2 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants