Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging): log unexpected exceptions as exceptions #14399

Merged
merged 1 commit into from
May 3, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Apr 29, 2021

SUMMARY

If an error makes its way all the way up the stack, we should definitely log it as an exception and not a warning.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  • manual testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #14399 (51130ea) into master (e7f5100) will decrease coverage by 0.26%.
The diff coverage is 0.00%.

❗ Current head 51130ea differs from pull request most recent head f117cf0. Consider uploading reports for the commit f117cf0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14399      +/-   ##
==========================================
- Coverage   76.79%   76.52%   -0.27%     
==========================================
  Files         955      955              
  Lines       48260    48260              
  Branches     6036     6036              
==========================================
- Hits        37060    36933     -127     
- Misses      11005    11132     +127     
  Partials      195      195              
Flag Coverage Δ
hive ?
mysql ?
postgres 81.06% <0.00%> (ø)
presto ?
python 81.11% <0.00%> (-0.50%) ⬇️
sqlite 80.67% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base.py 76.19% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.37% <0.00%> (-1.70%) ⬇️
superset/db_engine_specs/mysql.py 92.53% <0.00%> (-1.50%) ⬇️
superset/models/core.py 88.04% <0.00%> (-1.09%) ⬇️
superset/views/core.py 75.20% <0.00%> (-0.45%) ⬇️
superset/db_engine_specs/base.py 87.66% <0.00%> (-0.44%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f5100...f117cf0. Read the comment docs.

@nytai nytai merged commit 0b9fd24 into apache:master May 3, 2021
@nytai nytai deleted the tai/exception-logging branch May 3, 2021 19:42
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants