Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change xsm Icons and dnd icons to new dynamic icons #14419

Merged
merged 4 commits into from
May 13, 2021
Merged

refactor: change xsm Icons and dnd icons to new dynamic icons #14419

merged 4 commits into from
May 13, 2021

Conversation

pkdotson
Copy link
Member

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-04-29 at 2 31 57 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #14419 (54a2f52) into master (a52ff13) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14419   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files         955      955           
  Lines       48020    48020           
  Branches     6032     6032           
=======================================
  Hits        36946    36946           
  Misses      10876    10876           
  Partials      198      198
Flag Coverage Δ
javascript 71.57% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/controls/DndColumnSelectControl/Option.tsx 100.00% <100.00%> (ø)
...plore/components/controls/OptionControls/index.tsx 90.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52ff13...54a2f52. Read the comment docs.

@junlincc
Copy link
Member

junlincc commented May 5, 2021

/testenv up

@junlincc junlincc added explore:drag&drop Related to drag&drop in Explore frontend:refactor Related to refactoring the frontend labels May 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

@junlincc Ephemeral environment spinning up at http://34.220.17.159:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

geido
geido approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rusackas
rusackas approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 3eef38f into apache:master May 13, 2021
@rusackas rusackas deleted the xsm-icon branch May 13, 2021 05:52
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@pkdotson
refactor: change xsm Icons and dnd icons to new dynamic icons (apache…
54b556d 
…#14419)

* intial commit

* fix test and add more icons

* fix lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@pkdotson
refactor: change xsm Icons and dnd icons to new dynamic icons (apache…
039e04d 
…#14419)

* intial commit

* fix test and add more icons

* fix lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@pkdotson
refactor: change xsm Icons and dnd icons to new dynamic icons (apache…
9c94d36 
…#14419)

* intial commit

* fix test and add more icons

* fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@geido geido geido approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:drag&drop Related to drag&drop in Explore frontend:refactor Related to refactoring the frontend preset-io size/S 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pkdotson @junlincc @rusackas @geido @mistercrunch