Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade @emotion #14454

Merged
merged 3 commits into from
May 4, 2021
Merged

chore: upgrade @emotion #14454

merged 3 commits into from
May 4, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented May 4, 2021

SUMMARY

Upgrade emotion packages and bring in a couple of bugfixes in superset-ui: apache-superset/superset-ui@v0.17.41...v0.17.42

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Everything should look the same

TEST PLAN

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #14454 (224d1c3) into master (2242f74) will increase coverage by 0.24%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14454      +/-   ##
==========================================
+ Coverage   76.86%   77.11%   +0.24%     
==========================================
  Files         952      952              
  Lines       48124    48150      +26     
  Branches     6054     6050       -4     
==========================================
+ Hits        36989    37129     +140     
+ Misses      10934    10820     -114     
  Partials      201      201              
Flag Coverage Δ
hive 80.80% <ø> (?)
javascript 71.91% <95.23%> (-0.01%) ⬇️
mysql 81.06% <ø> (ø)
postgres 81.09% <ø> (+0.01%) ⬆️
presto 80.79% <ø> (?)
python 81.62% <ø> (+0.46%) ⬆️
sqlite 80.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Label/index.tsx 100.00% <ø> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx 2.33% <ø> (ø)
...ontrols/FilterControl/AdhocFilterControl/index.jsx 57.69% <ø> (ø)
...components/controls/FixedOrMetricControl/index.jsx 83.92% <ø> (ø)
superset-frontend/src/views/menu.tsx 0.00% <0.00%> (ø)
...t-frontend/src/SqlLab/components/ColumnElement.tsx 95.45% <100.00%> (ø)
superset-frontend/src/components/Icons/Icon.tsx 96.00% <100.00%> (ø)
...set-frontend/src/components/ListViewCard/index.tsx 100.00% <100.00%> (ø)
superset-frontend/src/components/Modal/Modal.tsx 100.00% <100.00%> (ø)
superset-frontend/src/components/Select/styles.tsx 84.72% <100.00%> (-0.21%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2242f74...224d1c3. Read the comment docs.

@ktmud
Copy link
Member Author

ktmud commented May 4, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

@ktmud Ephemeral environment spinning up at http://52.27.113.49:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@ktmud ktmud merged commit 23014e9 into master May 4, 2021
@ktmud ktmud deleted the upgrade-emotion branch May 4, 2021 22:26
@ktmud
Copy link
Member Author

ktmud commented May 4, 2021

Merging to unblock other changes to superset-ui.

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants