Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change warning icon to use icons #14462

Closed
wants to merge 3 commits into from

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented May 4, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Screen Shot 2021-05-04 at 8 38 29 AM

after
Screen Shot 2021-05-04 at 8 38 43 AM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #14462 (5e7ceb6) into master (b179863) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 5e7ceb6 differs from pull request most recent head 354104b. Consider uploading reports for the commit 354104b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14462      +/-   ##
==========================================
- Coverage   77.25%   77.11%   -0.14%     
==========================================
  Files         969      957      -12     
  Lines       50013    48152    -1861     
  Branches     6431     6056     -375     
==========================================
- Hits        38636    37131    -1505     
+ Misses      11174    10820     -354     
+ Partials      203      201       -2     
Flag Coverage Δ
javascript 71.91% <100.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx 58.33% <100.00%> (+2.08%) ⬆️
...src/filters/components/Range/RangeFilterPlugin.tsx 0.00% <0.00%> (-88.68%) ⬇️
...end/src/filters/components/Range/transformProps.ts 20.00% <0.00%> (-80.00%) ⬇️
...ontend/src/filters/components/Select/buildQuery.ts 25.00% <0.00%> (-75.00%) ⬇️
...c/visualizations/TimeTable/TimeTableChartPlugin.js 0.00% <0.00%> (-75.00%) ⬇️
...et-frontend/src/components/Menu/LanguagePicker.tsx 64.28% <0.00%> (-35.72%) ⬇️
superset-frontend/src/modules/utils.js 52.63% <0.00%> (-30.71%) ⬇️
...set-frontend/src/filters/components/Range/index.ts 60.00% <0.00%> (-30.00%) ⬇️
...frontend/src/filters/components/TimeGrain/index.ts 60.00% <0.00%> (-30.00%) ⬇️
...rontend/src/filters/components/TimeColumn/index.ts 60.00% <0.00%> (-30.00%) ⬇️
... and 297 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b179863...354104b. Read the comment docs.

@junlincc junlincc added the frontend:refactor Related to refactoring the frontend label May 5, 2021
@pkdotson
Copy link
Member Author

Going to close this as there is no longer an icon for add dataset modal

@pkdotson pkdotson closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend:refactor Related to refactoring the frontend preset-io size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants