fix(dashboard): Prevent char overflow when displaying chart description #14467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-ajay
changed the title
Codecov Report
@@ Coverage Diff @@
## master #14467 +/- ##
==========================================
- Coverage 77.12% 77.12% -0.01%
==========================================
Files 954 953 -1
Lines 48175 48176 +1
Branches 6063 6053 -10
==========================================
Hits 37155 37155
- Misses 10819 10820 +1
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| // fix for https://github.com/apache/superset/issues/12643 | ||
| if (prevProps.isExpanded !== this.props.isExpanded) { | ||
| this.forceUpdate(); | ||
| } |
There was a problem hiding this comment.
forceUpdate() is a solution but we should try to avoid all uses of forceUpdate() and only read from this.props and this.state in render().
So i suggest we do this:
- add
descriptionHeightin component state, initial value = 0 - add
componentDidUpdateso that we can set descriptionHeight state wheneverisExpandedprop is changed:
componentDidUpdate(prevProps, prevState, snapshot) {
if (this.props.isExpanded !== prevProps.isExpanded) {
const descriptionHeight =
this.props.isExpanded && this.descriptionRef
? this.descriptionRef.offsetHeight
: 0;
this.setState({
descriptionHeight,
})
}
}
- in
shouldComponentUpdate, if descriptionHeight state is changed, just like height state is change, should return true:
if (
nextState.width !== this.state.width ||
nextState.height !== this.state.height ||
nextState.descriptionHeight !== this.state.descriptionHeight
) {
return true;
}
- in the end,
getChartHeight()function should return chart content height by height and descriptionHeight:
getChartHeight() {
const headerHeight = this.getHeaderHeight();
return this.state.height - headerHeight - this.state.descriptionHeight;
}
|
/testenv up |
|
@junlincc Ephemeral environment spinning up at http://34.222.14.1:8080. Credentials are |
|
|
|
Ephemeral environment shutdown and build artifacts deleted. |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…on (apache#14467) * Force refresh the chart on toggle display description * Use forceUpdate instead of forceRefresh * Instead of forceUpdate, add a state for desciption height Co-authored-by: Ajay Mancheery <ajaymancheery@Ajays-MacBook-Pro.local>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…on (apache#14467) * Force refresh the chart on toggle display description * Use forceUpdate instead of forceRefresh * Instead of forceUpdate, add a state for desciption height Co-authored-by: Ajay Mancheery <ajaymancheery@Ajays-MacBook-Pro.local>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…on (apache#14467) * Force refresh the chart on toggle display description * Use forceUpdate instead of forceRefresh * Instead of forceUpdate, add a state for desciption height Co-authored-by: Ajay Mancheery <ajaymancheery@Ajays-MacBook-Pro.local>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #12643
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TEST PLAN
CI and manual test
ADDITIONAL INFORMATION