chore: Adding logging for datasource/save requests

[michellethomas]

SUMMARY

I'd like to log requests to the /datasource/save endpoint so that we know when users alter a datasource.

(Edit: I was previously concerned about logging large data blobs in the json field but the size of this seems in line with other large payloads we are logging like /save_dash, the database like mysql will truncate large blobs). The data that automatically gets logged in the json column can be large (it includes all of the data for the datasource that is getting saved so if the datasource has a lot of columns they will all get logged).

TEST PLAN

Edited a datasource from the /tablemodelview/list/ and explore pages, confirmed logs in the logs table.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

@john-bodley @etr2460

[michellethomas]

I just checked the logs and looks like mysql will truncate at 65535 characters, the /save_dash endpoint is also large so this seems in line with what we are already logging.

[codecov]

Codecov Report

Merging #14476 (39d212c) into master (b4e527a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #14476      +/-   ##
==========================================
+ Coverage   76.91%   76.95%   +0.03%     
==========================================
  Files         955      955              
  Lines       48057    48108      +51     
  Branches     6034     6034              
==========================================
+ Hits        36965    37023      +58     
+ Misses      10894    10887       -7     
  Partials      198      198              

Flag	Coverage Δ
hive	80.80% <100.00%> (+0.05%)	⬆️
mysql	81.06% <100.00%> (+0.05%)	⬆️
postgres	81.09% <100.00%> (+0.05%)	⬆️
presto	80.80% <100.00%> (+0.06%)	⬆️
python	81.63% <100.00%> (+0.06%)	⬆️
sqlite	80.70% <100.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/datasource.py	88.52% <100.00%> (+0.19%)	⬆️
superset/views/core.py	75.51% <0.00%> (-0.14%)	⬇️
superset/models/core.py	89.13% <0.00%> (ø)
superset/db_engine_specs/base.py	88.09% <0.00%> (ø)
superset/databases/schemas.py	99.52% <0.00%> (+<0.01%)	⬆️
superset/db_engine_specs/postgres.py	96.93% <0.00%> (+0.03%)	⬆️
superset/models/slice.py	86.03% <0.00%> (+0.07%)	⬆️
superset/charts/api.py	81.92% <0.00%> (+0.10%)	⬆️
superset/utils/core.py	89.00% <0.00%> (+0.22%)	⬆️
superset/sql_lab.py	81.90% <0.00%> (+0.33%)	⬆️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e527a...39d212c. Read the comment docs.

[etr2460]

lgtm