New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Explore layout is sometimes too short for the viewport #14481
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14481 +/- ##
=======================================
Coverage 77.11% 77.11%
=======================================
Files 952 952
Lines 48159 48159
Branches 6050 6050
=======================================
Hits 37137 37137
Misses 10821 10821
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@junlincc Container image not yet published for this PR. Please try again when build is complete. |
@junlincc Ephemeral environment creation failed. Please check the Actions logs for details. |
/testenv up |
@rusackas Ephemeral environment spinning up at http://54.218.151.238:8080. Credentials are |
Glad this is fixed, exciting! LGTM |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Flex layout in the explore section usually looks OK, but when things are in an error state, and all three columns are shorter than the viewport, that means the whole layout can get too short, making a weird gap under the menu. This sets a
flex-basis
property that's plenty tall (the entire viewport) to take up the space, and then flexbox will shrink things as needed.Issue reported by @srinify
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Select a dataset without too many fields (so the list is short)
Find a viz with a sufficiently short control panel (either tab in the control panel, as seen in the gifs above)
Put the chart in an error state so it loses its height.
Witness the layout shift at the top (or... hopefully not).
ADDITIONAL INFORMATION