Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explore layout is sometimes too short for the viewport #14481

Merged
merged 1 commit into from May 5, 2021

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented May 5, 2021

SUMMARY

Flex layout in the explore section usually looks OK, but when things are in an error state, and all three columns are shorter than the viewport, that means the whole layout can get too short, making a weird gap under the menu. This sets a flex-basis property that's plenty tall (the entire viewport) to take up the space, and then flexbox will shrink things as needed.

Issue reported by @srinify

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
problem2

After:
solution

TEST PLAN

Select a dataset without too many fields (so the list is short)
Find a viz with a sufficiently short control panel (either tab in the control panel, as seen in the gifs above)
Put the chart in an error state so it loses its height.
Witness the layout shift at the top (or... hopefully not).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested review from srinify and pkdotson May 5, 2021 07:22
@rusackas rusackas changed the title fix: adding flex-basis for Explore layout which is sometimes too short fix: Explore layout is sometimes too short for the viewport May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #14481 (d282558) into master (5aef6bc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14481   +/-   ##
=======================================
  Coverage   77.11%   77.11%           
=======================================
  Files         952      952           
  Lines       48159    48159           
  Branches     6050     6050           
=======================================
  Hits        37137    37137           
  Misses      10821    10821           
  Partials      201      201           
Flag Coverage Δ
hive 80.79% <ø> (ø)
javascript 71.91% <ø> (ø)
mysql 81.05% <ø> (ø)
postgres 81.09% <ø> (ø)
presto 80.79% <ø> (ø)
python 81.62% <ø> (ø)
sqlite 80.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx 2.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aef6bc...d282558. Read the comment docs.

@junlincc
Copy link
Member

junlincc commented May 5, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

@junlincc Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

@junlincc Ephemeral environment creation failed. Please check the Actions logs for details.

@rusackas
Copy link
Member Author

rusackas commented May 5, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

@rusackas Ephemeral environment spinning up at http://54.218.151.238:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@srinify
Copy link
Contributor

srinify commented May 5, 2021

Glad this is fixed, exciting! LGTM

@pkdotson pkdotson merged commit 8ccd196 into master May 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2021

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas deleted the fix-explore-flex-layout branch May 5, 2021 17:35
@rusackas rusackas added the bash! label May 12, 2021
@junlincc junlincc added the rush! Requires immediate attention label May 18, 2021
@junlincc junlincc removed the rush! Requires immediate attention label May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants