Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix #13831 #14490

Merged
merged 1 commit into from May 5, 2021
Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Closes #13831.

@junlincc @zuzana-vej @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Check #13831 for before screenshots.

Screen Shot 2021-05-05 at 11 15 04 AM

Screen Shot 2021-05-05 at 11 15 18 AM

TEST PLAN

1 - Try to select a certified saved metric with a big name
2 - Check that the icon appears and the text has an ellipsis

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #14490 (a3446b7) into master (b030c98) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a3446b7 differs from pull request most recent head fcaef46. Consider uploading reports for the commit fcaef46 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14490   +/-   ##
=======================================
  Coverage   77.12%   77.12%           
=======================================
  Files         953      953           
  Lines       48189    48191    +2     
  Branches     6051     6051           
=======================================
+ Hits        37166    37168    +2     
  Misses      10822    10822           
  Partials      201      201           
Flag Coverage Δ
javascript 71.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 78.62% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b030c98...fcaef46. Read the comment docs.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit f9567ef into apache:master May 5, 2021
@rusackas rusackas added the bash! label May 12, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[explore] Certified metric icons are various sizes on Metric control
4 participants