chore: Removes tabs pane animation by default #14496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
changed the title
michael-s-molina
force-pushed
the
remove-tabs-animation-by-default
branch
from
b528344
to
7e340a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #14496 +/- ##
=======================================
Coverage 77.12% 77.12%
=======================================
Files 953 953
Lines 48189 48189
Branches 6051 6051
=======================================
Hits 37166 37166
Misses 10822 10822
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@rusackas Ephemeral environment spinning up at http://52.42.86.162:8080. Credentials are |
junlin-qa
approved these changes
May 8, 2021
|
Ephemeral environment shutdown and build artifacts deleted. |
7 tasks
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removes tabs pane animation by default. Keeps the animation of the ink bar. Some screens were presenting weird behaviour because of the animations.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-05-05-at-20445-pm_uKOfUxkJ.mov
Screen.Recording.2021-05-05.at.2.13.38.PM.mov
@rusackas @pkdotson
TEST PLAN
All tabs should have only ink bar animation by default.
ADDITIONAL INFORMATION