Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Query History #14498

Merged
merged 2 commits into from
May 5, 2021
Merged

fix: Query History #14498

merged 2 commits into from
May 5, 2021

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented May 5, 2021

SUMMARY

Query History Tab in SQL Lab was animated which gives it a margin-left of -100%

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-05-05.at.2.19.14.PM.mov

AFter:
Screen Shot 2021-05-05 at 3 32 01 PM

TEST PLAN

Visual Test

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh self-requested a review May 5, 2021 20:03
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #14498 (cdfeb03) into master (ae256a9) will not change coverage.
The diff coverage is n/a.

❗ Current head cdfeb03 differs from pull request most recent head 32165e2. Consider uploading reports for the commit 32165e2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14498   +/-   ##
=======================================
  Coverage   77.09%   77.09%           
=======================================
  Files         953      953           
  Lines       48189    48189           
  Branches     6051     6051           
=======================================
  Hits        37153    37153           
  Misses      10835    10835           
  Partials      201      201           
Flag Coverage Δ
javascript 71.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/SqlLab/components/SouthPane/SouthPane.tsx 79.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae256a9...32165e2. Read the comment docs.

@hughhhh hughhhh merged commit 12baba0 into apache:master May 5, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix for QUery History

* fixed
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix for QUery History

* fixed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix for QUery History

* fixed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants