fix(viz): apply uniform sorting to all nvd3 timeseries charts #14539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Many NVD3 timeseries viz' were featured duplicated sorting logic that was missing from others. This introduces sorting logic to the base
NVD3TimeSeriesViz
class removes the same from the following viz':NVD3TimeSeriesStackedViz
(=area chart)HorizonViz
RoseViz
PartitionViz
By moving the sorting logic to the base class, this logic is now added to the following chart types that were previously missing it:
NVD3TimeSeriesViz
(=line chart)NVD3TimeSeriesBarViz
NVD3CompareTimeSeriesViz
The following charts that extend the
NVD3TimeSeriesViz
class are unaffected, since they don't feature the sorting control:NVD3TimePivotViz
TEST PLAN
All eight charts that this PR affects were manually tested to ensure that they work as expected.
ADDITIONAL INFORMATION