Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Column name and icons alignment in the Datasource Panel (Explore) #14551

Merged
merged 3 commits into from
May 11, 2021
Merged

fix: Column name and icons alignment in the Datasource Panel (Explore) #14551

merged 3 commits into from
May 11, 2021

Conversation

geido
Copy link
Member

@geido geido commented May 10, 2021

SUMMARY

Fixes #13449 by changing the alignment of the column name and icons in the Datasource Panel.

BEFORE

before

AFTER

after_ellipsis

TEST PLAN

  1. Open a chart in Explore
  2. Edit the dataset and change the label of a column with a very long one
  3. Make sure that the left icons, the column name, and tooltip icon are showing on the same line and that the column name cuts with ellipsis
  4. Make sure the responsive behavior works when the Datasource panel width is increased/decreased

ADDITIONAL INFORMATION

@geido
Copy link
Member Author

geido commented May 10, 2021

@junlincc @rusackas

@codecov
Copy link

codecov bot commented May 10, 2021 •
edited
Loading

Codecov Report

Merging #14551 (65ee8cd) into master (0fe2bf1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14551   +/-   ##
=======================================
  Coverage   77.40%   77.40%           
=======================================
  Files         958      958           
  Lines       48326    48326           
  Branches     5677     5677           
=======================================
  Hits        37405    37405           
  Misses      10721    10721           
  Partials      200      200
Flag Coverage Δ
javascript 72.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/explore/components/optionRenderers.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fe2bf1...65ee8cd. Read the comment docs.

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://54.202.213.120:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

junlincc commented May 10, 2021 •
edited
Loading

Thanks for the PR! the AFTER screen shot looks right, but what im seeing locally looks different.

Screen Shot 2021-05-10 at 12 39 00 PM

@junlincc junlincc added the hold:testing! On hold for testing label May 10, 2021
@geido
Copy link
Member Author

geido commented May 11, 2021

Thanks for spotting that @junlincc. That was a problem specifically for names with spaces, affecting both Columns and Metrics. It's fixed now.

@junlincc
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://34.220.154.116:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

perfect after the fix thanks!
Screen Shot 2021-05-11 at 10 25 32 AM

@junlincc junlincc requested a review from rusackas May 11, 2021 17:26
rusackas
rusackas approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rusackas rusackas merged commit 3a4536a into apache:master May 11, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas added the bash! label May 12, 2021
@junlincc junlincc added rush! Requires immediate attention and removed hold:testing! On hold for testing labels May 14, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request May 18, 2021
@geido @henryyeh
fix: Column name and icons alignment in the Datasource Panel (Explore) (
4daa87f 
apache#14551)

* Fix column name alignment

* Fix space wrap

(cherry picked from commit 3a4536a)
@junlincc junlincc removed the rush! Requires immediate attention label May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@geido
fix: Column name and icons alignment in the Datasource Panel (Explore) (
0161ed0 
apache#14551)

* Fix column name alignment

* Fix space wrap
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@geido
fix: Column name and icons alignment in the Datasource Panel (Explore) (
a3c2d8a 
apache#14551)

* Fix column name alignment

* Fix space wrap
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@geido
fix: Column name and icons alignment in the Datasource Panel (Explore) (
34e6676 
apache#14551)

* Fix column name alignment

* Fix space wrap
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@junlin-qa junlin-qa junlin-qa approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Explore] Long columns and metrics with descriptions wrap differently in Dataset panel
5 participants
@geido @junlincc @rusackas @junlin-qa @mistercrunch