feat: bumping echarts plugin, adding new treemap plugin #14560
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14560 +/- ##
==========================================
+ Coverage 77.38% 77.47% +0.08%
==========================================
Files 959 959
Lines 48465 48465
Branches 5678 5678
==========================================
+ Hits 37506 37547 +41
+ Misses 10759 10718 -41
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@rusackas Container image not yet published for this PR. Please try again when build is complete. |
|
@rusackas Ephemeral environment creation failed. Please check the Actions logs for details. |
|
because we didn't give the new chart a new name, looks like all the old treemap already migrated to echarts treemap? that will be great we dont even need migration script. 😅 |
| @@ -122,7 +123,6 @@ export default class MainPreset extends Preset { | |||
| new TableChartPlugin().configure({ key: 'table' }), | |||
| new TimePivotChartPlugin().configure({ key: 'time_pivot' }), | |||
| new TimeTableChartPlugin().configure({ key: 'time_table' }), | |||
| new TreemapChartPlugin().configure({ key: 'treemap' }), | |||
There was a problem hiding this comment.
Maybe not a direct replacement from nvd3-treemap to echart -treemap
- We should need some migration scripts, adapt to the new Treemap.
- fix original cypress CI
|
@rusackas can you push a commit to rename the echarts treemap to treemap 2 to get the ci pass? my understanding is that we still need to work on the migration script.... |
zhaoyongjie
force-pushed
the
bumping-echarts
branch
from
52bee9f
to
3a99e34
Compare
thanks @stephenLYZ for your hard works!
|
zhaoyongjie
changed the title
|
/testenv up |
|
@rusackas @zhaoyongjie can we get the checks pass? thank you for bumping the plugins! |
|
@junlincc Ephemeral environment spinning up at http://34.221.64.152:8080. Credentials are |
| @@ -91,7 +91,7 @@ | |||
| "@superset-ui/legacy-preset-chart-big-number": "^0.17.42", | |||
| "@superset-ui/legacy-preset-chart-deckgl": "^0.4.6", | |||
| "@superset-ui/legacy-preset-chart-nvd3": "^0.17.42", | |||
| "@superset-ui/plugin-chart-echarts": "^0.17.44", | |||
| "@superset-ui/plugin-chart-echarts": "^0.17.47", | |||
There was a problem hiding this comment.
I think bumping this to 0.17.47 without also bumping superset-ui/core first to 0.17.46 might be problematic. I suggest merging this first: #14547 , after which this should update cleanly.
|
Ephemeral environment shutdown and build artifacts deleted. |
* chore: bumping echarts plugin * feat: Upgrading to new treemap * bump @superset-ui/plugin-chart-echarts 0.17.47 Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* chore: bumping echarts plugin * feat: Upgrading to new treemap * bump @superset-ui/plugin-chart-echarts 0.17.47 Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* chore: bumping echarts plugin * feat: Upgrading to new treemap * bump @superset-ui/plugin-chart-echarts 0.17.47 Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
mistercrunch
added
🏷️ bot
SUMMARY
Bumps the Echarts plugin, and replaces the old treemap with the new one. We need to consider a proper migration, but this PR and its ephemeral environment can serve as a preview for both the new treemap, and for the updated/polished funnel.
@junlincc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TEST PLAN
ADDITIONAL INFORMATION