Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explore): #10098 boolean filter not working #14567

Merged
merged 11 commits into from
May 18, 2021
Merged

fix(explore): #10098 boolean filter not working #14567

merged 11 commits into from
May 18, 2021

Commits on May 10, 2021

  1. Restrict operators when column is boolean

    @m-ajay
    m-ajay committed May 10, 2021
    Configuration menu
    Copy the full SHA
    b74e312 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. refactor 'isOperatorRelevant' a little bit

    @m-ajay
    m-ajay committed May 11, 2021
    Configuration menu
    Copy the full SHA
    c45ec02 View commit details
    Browse the repository at this point in the history

  2. Include 'BOOLEAN' to handle presto

    @m-ajay
    m-ajay committed May 11, 2021
    Configuration menu
    Copy the full SHA
    f25d0fb View commit details
    Browse the repository at this point in the history

  3. Update tests

    @m-ajay
    m-ajay committed May 11, 2021
    Configuration menu
    Copy the full SHA
    682f291 View commit details
    Browse the repository at this point in the history

  4. number column should show bool operators

    @m-ajay
    m-ajay committed May 11, 2021
    Configuration menu
    Copy the full SHA
    9024352 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. fix test - some dbs translate true/false to 1/0

    @m-ajay
    m-ajay committed May 12, 2021
    Configuration menu
    Copy the full SHA
    541b3b8 View commit details
    Browse the repository at this point in the history

  2. Fix tests and add linting

    @m-ajay
    m-ajay committed May 12, 2021
    Configuration menu
    Copy the full SHA
    24c0161 View commit details
    Browse the repository at this point in the history

  3. When column type is boolean, show bool operators

    @m-ajay
    m-ajay committed May 12, 2021
    Configuration menu
    Copy the full SHA
    cef4926 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Address PR comments - simplify conditions

    @m-ajay
    m-ajay committed May 17, 2021
    Configuration menu
    Copy the full SHA
    a3f6b76 View commit details
    Browse the repository at this point in the history

  2. Fix a linting error

    @m-ajay
    m-ajay committed May 17, 2021
    Configuration menu
    Copy the full SHA
    f5373ff View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Addressing PR comment - remove unused variables

    @m-ajay
    m-ajay committed May 18, 2021
    Configuration menu
    Copy the full SHA
    32ebf1c View commit details
    Browse the repository at this point in the history