feat(native-filters): add sort metric to select #14590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
force-pushed
the
villebro/sort-metric-2
branch
4 times, most recently
from
d5b9228
to
71aff47
Compare
villebro
force-pushed
the
villebro/sort-metric-2
branch
from
71aff47
to
b9b2aff
Compare
Codecov Report
@@ Coverage Diff @@
## master #14590 +/- ##
==========================================
+ Coverage 77.40% 77.42% +0.01%
==========================================
Files 958 958
Lines 48329 48330 +1
Branches 5679 5680 +1
==========================================
+ Hits 37410 37420 +10
+ Misses 10719 10710 -9
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
graceguo-supercat
approved these changes
May 12, 2021
11 tasks
amitmiran137
pushed a commit
that referenced
this pull request
May 13, 2021
(cherry picked from commit f1c32b9)
serenajiang
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
May 17, 2021
junlincc
added
the
dashboard:native-filters
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Sep 8, 2021
(cherry picked from commit f1c32b9)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 1.2.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some databases require including the sort metrics in the select. To maximise database compatibility and make it possible to add tooltips to show the metric value used (later PR), we add the metric to the select filter.
TEST PLAN
CI + new tests added
ADDITIONAL INFORMATION