-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error icon spacing in explore #14597
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14597 +/- ##
==========================================
+ Coverage 77.16% 77.18% +0.01%
==========================================
Files 958 958
Lines 48331 48332 +1
Branches 5679 5680 +1
==========================================
+ Hits 37295 37305 +10
+ Misses 10836 10827 -9
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@junlincc Ephemeral environment spinning up at http://54.245.41.232:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! product sign-off
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
* fix error message icon * lint (cherry picked from commit 5f7722c)
* fix error message icon * lint
* fix error message icon * lint
* fix error message icon * lint
SUMMARY
This pr fixes the padding issue for the error message in explore.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
TEST PLAN
ADDITIONAL INFORMATION