Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explore): Missing border in the Popover SQL Editor #14609

Merged
merged 1 commit into from
May 14, 2021
Merged

fix(explore): Missing border in the Popover SQL Editor #14609

merged 1 commit into from
May 14, 2021

Conversation

geido
Copy link
Member

@geido geido commented May 13, 2021 •
edited
Loading

SUMMARY

Fixes #14598

The border was missing due to a change in the class name introduced by PR #14502. The class name has been reverted.

BEFORE

Screen Shot 2021-05-13 at 12 05 39

AFTER

after_popover_border

TEST PLAN

  1. Open a chart in Explore
  2. Open the Metrics in the control panel
  3. Select the "Custom SQL" tab
  4. Make sure the textarea has a border

ADDITIONAL INFORMATION

  • Has associated issue: [Explore]missing editor input frame in Metrics popover  #14598
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
Copy link
Member Author

geido commented May 13, 2021

@junlincc @rusackas

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #14609 (19fb7ef) into master (3f6bd1e) will not change coverage.
The diff coverage is n/a.

❗ Current head 19fb7ef differs from pull request most recent head c27f7ed. Consider uploading reports for the commit c27f7ed to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14609   +/-   ##
=======================================
  Coverage   77.38%   77.38%           
=======================================
  Files         959      959           
  Lines       48465    48465           
  Branches     5678     5678           
=======================================
  Hits        37506    37506           
  Misses      10759    10759           
  Partials      200      200
Flag Coverage Δ
javascript 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 80.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f6bd1e...c27f7ed. Read the comment docs.

@geido geido changed the title fix: Missing border in the Popover SQL Editor in Explore fix(explore): Missing border in the Popover SQL Editor May 13, 2021
@junlincc
Copy link
Member

/testenv up

@junlincc junlincc added the bash! label May 13, 2021
@github-actions
Copy link
Contributor

@junlincc Ephemeral environment spinning up at http://34.221.203.254:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

rusackas
rusackas approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

michael-s-molina
michael-s-molina approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@suddjian suddjian merged commit 3466cb2 into apache:master May 14, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@junlincc junlincc added the rush! Requires immediate attention label May 18, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request May 18, 2021
@geido @henryyeh
Fix class name (apache#14609)
c5637db 
(cherry picked from commit 3466cb2)
@junlincc junlincc removed the rush! Requires immediate attention label May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@geido
Fix class name (apache#14609)
17c67d9
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@geido
Fix class name (apache#14609)
5d04995
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@geido
Fix class name (apache#14609)
b5af17a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Explore]missing editor input frame in Metrics popover
6 participants
@geido @junlincc @rusackas @michael-s-molina @mistercrunch @suddjian