feat: Export Chart to .xml format #14628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14628 +/- ##
==========================================
+ Coverage 77.20% 77.46% +0.25%
==========================================
Files 958 958
Lines 48492 48514 +22
Branches 5691 6061 +370
==========================================
+ Hits 37437 37579 +142
+ Misses 10855 10730 -125
- Partials 200 205 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@exemplary-citizen Thanks for this PR. Can you resolve the conflicts? @villebro Can you enable CI? |
|
@villebro Can you enable CI when you get a chance? |
|
I don't think the cypress failure is related to the changes in this PR. The bubble test that is failing does seem to have a history of instability #11630. Other than that, the rest of CI should come back green. |
|
Is there some specific use case for adding XML support? Since the data that's exported is mostly tabular, it feels like CSV and JSON should be adequate for most use cases. The reason I'm hesitant to add it is adding clutter to the already crowded chart header.. |
|
Yeah XML is definitely a very popular format especially for data exchange and interoperability. There are also a bunch of tools that provide functionality for migrating XML documents to tables or datasets including:
To alleviate your concern of adding clutter we could move all three buttons to an export dropdown like so: |
|
Going through old PRs and noticed this one. To continue this discussion, I like the idea of moving the export buttons to a more general export dropdown. However, to reiterate my original concern, I still feel adding XML export not really adding any new functionality, as it's really just exporting tabular data but in XML format (=same as the JSON export but in a nowadays less popular format). In addition, it will add maintenance burden to Superset developers, and is IMO a distraction from the core mission of Superset. If someone really wants to convert the data to XML, there's probably great tools for doing that from CSV/JSON formats. But if others feel otherwise I'm happy to resume this discussion if this is a highly requested feature. |
|
@exemplary-citizen with the recent redesign of chart actions in #19446, this feature wouldn't add any more clutter to the UI, which is a good thing. And since this is appears to be something very many people are eagerly awaiting, I don't want to be the person who blocks this feature. Also, given that many will be using it, I assume there will be a shared interest to maintain it, too. So feel free to rebase this, and I'll be happy to review and get this merged 🙂 👍 |
|
Hi @exemplary-citizen - echoing @villebro sentiment here that there would be a lot of interest here if this could be rebased and brought back up to speed. Let us know if you have any intent to do so (or not). Thanks! |
|
@exemplary-citizen could you rebase the branch and re-push the commit if you still work on this? |
SUMMARY
This PR allows you to export charts to an xml file in the same manner we currently are able to with json and csv.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Added tests for the chart api in a similar flavor to the existing csv export tests.
ADDITIONAL INFORMATION
Fixes the XML part of #14415
cc @srinify @junlincc