fix: Removing specific column widths, letting things flex naturally. #14637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #14637 +/- ##
==========================================
- Coverage 77.47% 77.23% -0.25%
==========================================
Files 958 958
Lines 48486 48481 -5
Branches 5679 5681 +2
==========================================
- Hits 37565 37443 -122
- Misses 10721 10838 +117
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
approved these changes
May 14, 2021
kgabryje
approved these changes
May 14, 2021
kgabryje
reviewed
May 14, 2021
| @@ -158,7 +158,6 @@ const SubMenuComponent: React.FunctionComponent<SubMenuProps> = props => { | |||
| const [navRightStyle, setNavRightStyle] = useState('nav-right'); | |||
| const [navRightCol, setNavRightCol] = useState(8); | |||
|
|
|||
| const { headerSize = 2 } = props; | |||
There was a problem hiding this comment.
I think that we can remove headerSize from SubMenuProps (line 153), it doesn't seem to be used anymore.
There was a problem hiding this comment.
We can also remove passing headerSize to SubMenu from CssTemplatesList and AnnotationLayersList
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
May 18, 2021
…pache#14637) (cherry picked from commit bf90885)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The SubMenu component was recently re-jiggered to use a grid (row/col) layout, and the text/header was given a fixed width, which caused line-wrapping. This PR uses the Row component's automatic layout to avoid this.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
Go to Alerts and Reports, and make sure you don't see awkward line-wrapping when the browser is narrow.
ADDITIONAL INFORMATION