Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes react-bootstrap and react-bootstrap-slider #14641

Merged
merged 1 commit into from
May 17, 2021

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented May 14, 2021

SUMMARY

Removes react-bootstrap and react-bootstrap-slider.

πŸ₯³ πŸ•ΊπŸΌ βœ… πŸ’― 🎊 πŸ’ͺ🏼 πŸ’₯ πŸ”₯

@junlincc @rusackas

Depends on: apache-superset/superset-ui#1108

TEST PLAN

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #14641 (cef3b1e) into master (97c9e37) will not change coverage.
The diff coverage is n/a.

❗ Current head cef3b1e differs from pull request most recent head f1fc238. Consider uploading reports for the commit f1fc238 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14641   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         958      958           
  Lines       48478    48478           
  Branches     5681     5681           
=======================================
  Hits        37553    37553           
  Misses      10725    10725           
  Partials      200      200           
Flag Coverage Ξ”
hive 80.94% <ΓΈ> (ΓΈ)
mysql 81.21% <ΓΈ> (ΓΈ)
postgres 81.23% <ΓΈ> (ΓΈ)
presto 80.93% <ΓΈ> (ΓΈ)
python 81.76% <ΓΈ> (ΓΈ)
sqlite 80.85% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 97c9e37...f1fc238. Read the comment docs.

@junlincc
Copy link
Member

junlincc commented May 14, 2021

Thank you so much for completing πŸ’― the project(all the dangerous work is done), your work is much appreciated. @michael-s-molina πŸ™

cc @mistercrunch

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YESSSSSSSS!!!!!!!!!

Champagne

@rusackas rusackas merged commit 1b47902 into apache:master May 17, 2021
@michael-s-molina michael-s-molina added this to In progress in AntD Transition (SIP-48) via automation Jun 28, 2021
@michael-s-molina michael-s-molina moved this from In progress to Done in AntD Transition (SIP-48) Jun 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚒 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚒 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants