Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add headers for DatabaseModal #14647

Merged
merged 7 commits into from
May 19, 2021
Merged

feat: Add headers for DatabaseModal #14647

merged 7 commits into from
May 19, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 14, 2021 •
edited
Loading

SUMMARY

Updated DB modal with headers and alerts

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-05-14 at 5 11 50 PM

Screen Shot 2021-05-14 at 5 11 25 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 14, 2021 •
edited
Loading

Codecov Report

Merging #14647 (089e47c) into master (74473e2) will increase coverage by 0.57%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14647      +/-   ##
==========================================
+ Coverage   77.20%   77.77%   +0.57%     
==========================================
  Files         958      958              
  Lines       48492    50269    +1777     
  Branches     5691     5991     +300     
==========================================
+ Hits        37437    39099    +1662     
- Misses      10855    10947      +92     
- Partials      200      223      +23
Flag Coverage Δ
hive 81.54% <ø> (?)
javascript 72.44% <100.00%> (-0.08%) ⬇️
mysql 81.84% <ø> (+0.63%) ⬆️
postgres 81.86% <ø> (+0.62%) ⬆️
presto 81.53% <ø> (?)
python 82.37% <ø> (+1.09%) ⬆️
sqlite 81.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/api.py 94.35% <ø> (+1.94%) ⬆️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 59.29% <100.00%> (+2.68%) ⬆️
...c/views/CRUD/data/database/DatabaseModal/styles.ts 97.46% <100.00%> (+1.46%) ⬆️
...UD/data/components/SyntaxHighlighterCopy/index.tsx 52.77% <0.00%> (-5.85%) ⬇️
...src/dashboard/components/dnd/handleScroll/index.ts 67.85% <0.00%> (-5.48%) ⬇️
...rontend/src/components/ListView/Filters/Search.tsx 84.21% <0.00%> (-2.46%) ⬇️
superset/exceptions.py 99.13% <0.00%> (-0.87%) ⬇️
superset/reports/logs/api.py 94.59% <0.00%> (-0.86%) ⬇️
superset/app.py 81.23% <0.00%> (-0.15%) ⬇️
superset/databases/schemas.py 99.42% <0.00%> (-0.13%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55418d...089e47c. Read the comment docs.

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 14, 2021
eschutho
eschutho approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@eschutho
Copy link
Member

🏷 hold:testing!
@hughhhh if you want to create an ephemeral env, I'll do a visual pass as well.

@hughhhh
Copy link
Member Author

hughhhh commented May 17, 2021

/testenv up

1 similar comment
@hughhhh
Copy link
Member Author

hughhhh commented May 17, 2021

/testenv up

@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment spinning up at http://18.237.103.108:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

1 similar comment
@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment spinning up at http://18.237.103.108:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@Steejay
Copy link

Steejay commented May 17, 2021

Screen Shot 2021-05-17 at 3 13 08 PM

can we align these edges

@hughhhh
Copy link
Member Author

hughhhh commented May 18, 2021

/testenv up

@Steejay
Copy link

Steejay commented May 18, 2021

Looks good to me @hughhhh

@hughhhh hughhhh added the need:merge The PR is ready to be merged label May 18, 2021
@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment spinning up at http://52.34.32.198:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh hughhhh merged commit 4160e45 into master May 19, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@hughhhh
feat: Add headers for DatabaseModal (apache#14647)
6d0cfa7 
* update styles sheets

* save this

* add backend

* update backend reference

* update styles

* my style updates

* sticky header
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@hughhhh
feat: Add headers for DatabaseModal (apache#14647)
d81b0dc 
* update styles sheets

* save this

* add backend

* update backend reference

* update styles

* my style updates

* sticky header
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@hughhhh
feat: Add headers for DatabaseModal (apache#14647)
c693fa4 
* update styles sheets

* save this

* add backend

* update backend reference

* update styles

* my style updates

* sticky header
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 12, 2024
@mistercrunch mistercrunch deleted the update-creds-3 branch March 25, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/L 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hughhhh @eschutho @Steejay @betodealmeida @mistercrunch