-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: roles undefined on public dashboards #14648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov Report
@@ Coverage Diff @@
## master #14648 +/- ##
=======================================
Coverage 77.37% 77.37%
=======================================
Files 958 958
Lines 48513 48513
Branches 5703 5703
=======================================
Hits 37535 37535
Misses 10777 10777
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
Fix for public dashboards where there is no user (but redux still has a "user" which is just an empty object)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Set
PUBLIC_ROLE_LIKE
config value to a role that can view dashboards, and view a dashboard as an anonymous user. It should show up.ADDITIONAL INFORMATION