Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: roles undefined on public dashboards #14648

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented May 14, 2021

SUMMARY

Fix for public dashboards where there is no user (but redux still has a "user" which is just an empty object)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Set PUBLIC_ROLE_LIKE config value to a role that can view dashboards, and view a dashboard as an anonymous user. It should show up.

ADDITIONAL INFORMATION

@suddjian suddjian added bash! need:review Requires a code review labels May 14, 2021
@suddjian suddjian requested a review from pkdotson May 14, 2021 20:40
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #14648 (aa0e09e) into master (f16c708) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14648   +/-   ##
=======================================
  Coverage   77.37%   77.37%           
=======================================
  Files         958      958           
  Lines       48513    48513           
  Branches     5703     5703           
=======================================
  Hits        37535    37535           
  Misses      10777    10777           
  Partials      201      201           
Flag Coverage Δ
hive 80.94% <ø> (ø)
javascript 72.51% <100.00%> (ø)
mysql 81.21% <ø> (ø)
postgres 81.23% <ø> (ø)
python 81.60% <ø> (ø)
sqlite 80.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/dashboard/util/findPermission.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16c708...aa0e09e. Read the comment docs.

@junlincc junlincc added the need:qa-review Requires QA review label May 14, 2021
@suddjian suddjian merged commit 884ded0 into master May 14, 2021
@suddjian suddjian deleted the fix-undefined-roles branch May 14, 2021 21:28
@suddjian suddjian linked an issue May 14, 2021 that may be closed by this pull request
3 tasks
@junlincc junlincc added rush! Requires immediate attention and removed rush! Requires immediate attention labels May 18, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:qa-review Requires QA review need:review Requires a code review preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public dashboard does not work due to JS error in findPermission.ts
4 participants