-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Register dynamic plugins and add feature checks #14650
chore: Register dynamic plugins and add feature checks #14650
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14650 +/- ##
==========================================
- Coverage 77.54% 77.30% -0.24%
==========================================
Files 958 958
Lines 48533 48541 +8
Branches 5702 5702
==========================================
- Hits 37633 37525 -108
- Misses 10699 10815 +116
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* chore: Register dynamic plugins and add feature checks * Disable pylint warning
* chore: Register dynamic plugins and add feature checks * Disable pylint warning
* chore: Register dynamic plugins and add feature checks * Disable pylint warning
SUMMARY
Following #14568, this PR removes conditional registration of the dynamic plugins resource and replaces it with a feature flag guard in a
before_request
hook.cc @suddjian @robdiciuccio