feat: Add Parameters fields to GET Database #14653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14653 +/- ##
==========================================
- Coverage 77.51% 77.30% -0.22%
==========================================
Files 958 958
Lines 48560 48598 +38
Branches 5703 5715 +12
==========================================
- Hits 37642 37568 -74
- Misses 10718 10829 +111
- Partials 200 201 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
8 tasks
|
/testenv up |
|
@pkdotson Ephemeral environment spinning up at http://54.188.67.191:8080. Credentials are |
hughhhh
commented
May 17, 2021
| @@ -81,10 +81,11 @@ describe('Add database', () => { | |||
| cy.get('[data-test="modal-confirm-button"]:not(:disabled)').click(); | |||
|
|
|||
| // should show error alerts | |||
| cy.get('.toast').contains('error').should('be.visible'); | |||
| // TODO(hugh): Update this test | |||
There was a problem hiding this comment.
We have a clubhouse ticket to re write this test once we are done with updating the modal
betodealmeida
requested changes
May 17, 2021
superset/databases/schemas.py
Outdated
Comment on lines
251
to
252
| if len(parameters.keys()) < 2: | ||
| return data |
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
superset/db_engine_specs/base.py
Outdated
Comment on lines
1312
to
1313
| def build_sqlalchemy_url(cls, parameters: Any) -> str: | ||
| raise NotImplementedError("build_sqlalchemy_url is not implemented") |
There was a problem hiding this comment.
This was renamed to build_sqlalchemy_uri:
Suggested change
| def build_sqlalchemy_url(cls, parameters: Any) -> str: | |
| raise NotImplementedError("build_sqlalchemy_url is not implemented") | |
| def build_sqlalchemy_uri(cls, parameters: Any) -> str: | |
| raise NotImplementedError("build_sqlalchemy_uri is not implemented") |
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
8 tasks
betodealmeida
approved these changes
May 19, 2021
| @@ -236,6 +237,18 @@ def backend(self) -> str: | |||
| sqlalchemy_url = make_url(self.sqlalchemy_uri_decrypted) | |||
| return sqlalchemy_url.get_backend_name() # pylint: disable=no-member | |||
|
|
|||
| @property | |||
| def parameters(self) -> Dict[str, Any]: | |||
| # Build parameters if db_engine_spec is a subclass of BasicParametersMixin | |||
There was a problem hiding this comment.
Nit:
Suggested change
| # Build parameters if db_engine_spec is a subclass of BasicParametersMixin | |
| # Build parameters if db_engine_spec supports it |
|
Ephemeral environment shutdown and build artifacts deleted. |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update the api to surface parameters in GET
database. This will be leveraged for whenever a user wants to edit a database assuming configuration type is dynamic.Also, updated all engine specs to allow for abstract classes while we implement them.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION