Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clear search on deleting search keyword #14655

Merged
merged 1 commit into from
May 17, 2021
Merged

fix: Clear search on deleting search keyword #14655

merged 1 commit into from
May 17, 2021

Conversation

geido
Copy link
Member

@geido geido commented May 16, 2021

SUMMARY

Fixes #14610
Fixes #13902

It clears out the search results when the search input is emptied.

BEFORE

dashboard_search_b4.mp4

AFTER

dashboard_search_after.mp4

TEST PLAN

  1. Go to a list view, such as Dashboards
  2. Search for a non-existing dashboard title
  3. Clear out the search input by deleting the keyword
  4. Make sure the search has been reset and the default search results are showing

ADDITIONAL INFORMATION

@geido
Copy link
Member Author

geido commented May 16, 2021

@junlincc @rusackas

@michael-s-molina
Copy link
Member

This PR also fixes #13902. It seems it's a duplicate of #14610. @geido Can you also add #13902 to the fixes list in the PR description so it's automatically closed?

@geido geido closed this May 17, 2021
@geido geido reopened this May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #14655 (4534c68) into master (4f5c537) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14655      +/-   ##
==========================================
- Coverage   77.54%   77.54%   -0.01%     
==========================================
  Files         958      958              
  Lines       48541    48543       +2     
  Branches     5702     5703       +1     
==========================================
+ Hits        37640    37641       +1     
- Misses      10700    10701       +1     
  Partials      201      201              
Flag Coverage Δ
javascript 72.51% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/components/ListView/Filters/Search.tsx 82.35% <75.00%> (-4.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5c537...4534c68. Read the comment docs.

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://34.212.234.217:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTG.

@pkdotson pkdotson merged commit ea96d95 into apache:master May 17, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas added the bash! label May 18, 2021
@junlincc junlincc added the rush! Requires immediate attention label May 18, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request May 18, 2021
(cherry picked from commit ea96d95)
@junlincc junlincc removed the rush! Requires immediate attention label May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
7 participants