-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clear search on deleting search keyword #14655
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14655 +/- ##
==========================================
- Coverage 77.54% 77.54% -0.01%
==========================================
Files 958 958
Lines 48541 48543 +2
Branches 5702 5703 +1
==========================================
+ Hits 37640 37641 +1
- Misses 10700 10701 +1
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@pkdotson Ephemeral environment spinning up at http://34.212.234.217:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTG.
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit ea96d95)
SUMMARY
Fixes #14610
Fixes #13902
It clears out the search results when the search input is emptied.
BEFORE
dashboard_search_b4.mp4
AFTER
dashboard_search_after.mp4
TEST PLAN
ADDITIONAL INFORMATION