Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Tag component overlap #14663

Merged
merged 1 commit into from
May 17, 2021
Merged

fix(explore): Tag component overlap #14663

merged 1 commit into from
May 17, 2021

Conversation

geido
Copy link
Member

@geido geido commented May 17, 2021

SUMMARY

Fixes #14607

Reintroduces the max-width that got lost during refactoring. For reference PR #12774

BEFORE

Screen Shot 2021-05-17 at 17 17 59

AFTER

Screen Shot 2021-05-17 at 17 12 35

TEST PLAN

  1. Open a deck.gl Screen Grid chart
  2. Make sure the "LONGITUDE AND LATITUDE" Tag component does not overlap with the "WEIGHT"

ADDITIONAL INFORMATION

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it!

@geido
Copy link
Member Author

geido commented May 17, 2021

@junlincc @rusackas

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #14663 (daec458) into master (4f5c537) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14663   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files         958      958           
  Lines       48541    48541           
  Branches     5702     5702           
=======================================
  Hits        37640    37640           
  Misses      10700    10700           
  Partials      201      201           
Flag Coverage Δ
javascript 72.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Label/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f5c537...daec458. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 9a9f093 into apache:master May 17, 2021
@junlincc junlincc added the rush! Requires immediate attention label May 18, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request May 18, 2021
(cherry picked from commit 9a9f093)
@junlincc junlincc removed the rush! Requires immediate attention label May 27, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cosmetic] deck.gl grid chart have elements overlapped in explore panel
5 participants