New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make config method optional #14668
Merged
hughhhh
merged 1 commit into
apache:master
from
preset-io:ch8325_makeConfigMethodOptional
May 17, 2021
Merged
feat: make config method optional #14668
hughhhh
merged 1 commit into
apache:master
from
preset-io:ch8325_makeConfigMethodOptional
May 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
eschutho
approved these changes
May 17, 2021
8 tasks
AAfghahi
force-pushed
the
ch8325_makeConfigMethodOptional
branch
from
May 17, 2021 17:56
d633b7b
to
240056f
Compare
Codecov Report
@@ Coverage Diff @@
## master #14668 +/- ##
==========================================
- Coverage 77.54% 77.30% -0.24%
==========================================
Files 958 958
Lines 48541 48541
Branches 5702 5702
==========================================
- Hits 37640 37525 -115
- Misses 10700 10815 +115
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
approved these changes
May 17, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 1.3.0
labels
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Config method being required is currently not letting people add databases, we are making it optional until we have added functionality in the database create frontend.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION