feat: redirect 404/500 to static pages #14677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
errorhandler_static_pages
branch
from
140cfab
to
6e47322
Compare
Codecov Report
@@ Coverage Diff @@
## master #14677 +/- ##
==========================================
- Coverage 77.55% 77.31% -0.24%
==========================================
Files 958 958
Lines 48549 48552 +3
Branches 5702 5703 +1
==========================================
- Hits 37651 37538 -113
- Misses 10697 10814 +117
+ Partials 201 200 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
commented
May 18, 2021
superset/views/base.py
Outdated
Comment on lines
367
to
370
| if not config["DEBUG"] and ex.code == 404: | ||
| return redirect("/static/assets/404.html") | ||
| if not config["DEBUG"] and ex.code == 500: | ||
| return redirect("/static/assets/500.html") |
There was a problem hiding this comment.
I'll update this to redirect only non-API calls.
nytai
approved these changes
May 19, 2021
|
@betodealmeida we haven't integrated these yet in Preset, it's a perpetual backlog item :). LGTM |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* feat: redirect 404/500 to static pages * Show pages only on html requests
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* feat: redirect 404/500 to static pages * Show pages only on html requests
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* feat: redirect 404/500 to static pages * Show pages only on html requests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We're currently returning a SIP-40 error payload on 404 and 500. I changed it to redirect the user to the static pages for these errors instead when running in production (not development).
@samtfm, @willbarrett how is this handled on the Preset side?
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION