feat: ability to pull from your own docker registry using a secret #14686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2021 13:31
junlincc
changed the title
jmistry
commented
May 19, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…pache#14686) * feature: ability to pull from your own docker registry using a secret * feature: ability to pull from your own docker registry using a secret * fix: formating * fix: formating * use secret for all deployments and jobs that use the helm chart * update chart version number Co-authored-by: jaisheel <jaisheel.mistry@partner.bmw.co.za>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…pache#14686) * feature: ability to pull from your own docker registry using a secret * feature: ability to pull from your own docker registry using a secret * fix: formating * fix: formating * use secret for all deployments and jobs that use the helm chart * update chart version number Co-authored-by: jaisheel <jaisheel.mistry@partner.bmw.co.za>
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…pache#14686) * feature: ability to pull from your own docker registry using a secret * feature: ability to pull from your own docker registry using a secret * fix: formating * fix: formating * use secret for all deployments and jobs that use the helm chart * update chart version number Co-authored-by: jaisheel <jaisheel.mistry@partner.bmw.co.za>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add ability to pull images from remote package registries that need image pull secrets. This is needed in many corporate environments where image copies are kept on the private registries
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
from the root of the repo execute the following
helm template test helm/supersetADDITIONAL INFORMATION