fix(explore): Don't run data panel query when control panel has errors #14687
Conversation
|
/testenv up |
Codecov Report
@@ Coverage Diff @@
## master #14687 +/- ##
==========================================
- Coverage 77.51% 77.50% -0.01%
==========================================
Files 958 958
Lines 48560 48566 +6
Branches 5703 5705 +2
==========================================
+ Hits 37642 37643 +1
- Misses 10718 10723 +5
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@junlincc Ephemeral environment spinning up at http://54.187.164.101:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
|
/testenv up |
|
@suddjian Ephemeral environment spinning up at http://34.212.75.202:8080. Credentials are |
| @@ -262,6 +282,9 @@ export const DataTablesPane = ({ | |||
| /> | |||
| ); | |||
| } | |||
| if (errorMessage) { | |||
| return <pre>{errorMessage}</pre>; | |||
There was a problem hiding this comment.
@kgabryje Can you replace, in this PR or in a follow up, both instances of <pre> with the Alert component just like the chart container?
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
SUMMARY
When a dataset doesn't have any saved metrics, the initial value of Metrics control is empty. There is a warning displayed in chart container, however data table(south) runs a query anyway. This PR fixes that behaviour - when control panel generates errors, they are passed down to data table(south) and displayed and no request to backend is sent.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION
CC: @junlincc @villebro