Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dry false config to CleanWebpackPlugin #14691

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

MatanBobi
Copy link
Contributor

@MatanBobi MatanBobi commented May 18, 2021

SUMMARY

After my superset/static folder reached 230Gb, I understood something is wrong with the CleanWebpackPlugin.
I've added a dry: false flag to the CleanWebpackPlugin as it must be explicitly set for the dangerouslyAllowCleanPatternsOutsideProject flag to work as written in the docs:
image

https://github.com/johnagan/clean-webpack-plugin/blob/master/README.md

Resolves #14690

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI - N/A
  • Includes DB Migration (follow approval process in SIP-59) - N/A
    • Migration is atomic, supports rollback & is backwards-compatible - N/A
    • Confirm DB migration upgrade and downgrade tested - N/A
    • Runtime estimates and downtime expectations provided - N/A
  • Introduces new feature or API - N/A
  • Removes existing feature or API - N/A

CC: @amitmiran137

@apache apache locked and limited conversation to collaborators May 18, 2021
@amitmiran137 amitmiran137 reopened this May 18, 2021
@kgabryje kgabryje closed this Jun 7, 2021
@kgabryje kgabryje reopened this Jun 7, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitmiran137 amitmiran137 merged commit 14598d4 into apache:master Jun 21, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Superset/static folder gets huge when running dev server
7 participants