Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check limiting factor on query results #14719

Merged
merged 1 commit into from
May 19, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented May 19, 2021

SUMMARY

There were errors on sql lab rendering because a translation key had a null replacement

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before in ticket

after:

Screen.Recording.2021-05-19.at.12.09.33.PM.mov

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue: [SQL_lab]sql editor page crash  #14711
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

closes #14711

@eschutho eschutho changed the title check limiting factor on query results fix: check limiting factor on query results May 19, 2021
@hughhhh
Copy link
Member

hughhhh commented May 19, 2021

/testenv up

@hughhhh hughhhh self-requested a review May 19, 2021 19:17
@eschutho eschutho force-pushed the elizabeth/fix-translation-render branch from 31b7f83 to 50c975e Compare May 19, 2021 19:20
@junlincc junlincc added rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels May 19, 2021
@github-actions
Copy link
Contributor

@hughhhh Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #14719 (50c975e) into master (4160e45) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14719   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files         959      959           
  Lines       48696    48697    +1     
  Branches     5739     5740    +1     
=======================================
+ Hits        37724    37725    +1     
  Misses      10771    10771           
  Partials      201      201           
Flag Coverage Δ
javascript 72.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/components/ResultSet.tsx 67.44% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4160e45...50c975e. Read the comment docs.

@hughhhh
Copy link
Member

hughhhh commented May 19, 2021

/testenv up

@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment spinning up at http://54.212.99.127:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@suddjian suddjian merged commit a9d888a into apache:master May 19, 2021
@junlincc junlincc removed the rush! Requires immediate attention label May 19, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@eschutho eschutho deleted the elizabeth/fix-translation-render branch May 19, 2021 23:01
@AAfghahi AAfghahi mentioned this pull request May 20, 2021
8 tasks
serenajiang pushed a commit to airbnb/superset-fork that referenced this pull request May 21, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels #bug:blocking! Blocking issues with high priority preset-io size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SQL_lab]sql editor page crash
5 participants