fix(sqllab): don't store user in localstorage

[suddjian]

SUMMARY

When the feature flag SQLLAB_BACKEND_PERSISTENCE is set to False, user data is currently saved in local storage. A recent change added roles information to the bootstrap user object. But with the flag off, local storage data ends up overwriting the bootstrap data, and the roles are lost, which breaks the page. This change removes user data from local storage, and prevents it from overwriting the bootstrap data.

TEST PLAN

• Turn the flag off
• checkout a commit from before a7a011cce5ea9a9ae6cebf40b6e5bc6257d7746d
• visit sql lab, execute a query (loads your user into localstorage)
• checkout this fix
• visit sql lab (user is removed from localstorage and page should show up)

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14722 (9e9c8c8) into master (67e3730) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #14722   +/-   ##
=======================================
  Coverage   77.45%   77.45%           
=======================================
  Files         959      959           
  Lines       48660    48702   +42     
  Branches     5734     5740    +6     
=======================================
+ Hits        37688    37724   +36     
- Misses      10771    10777    +6     
  Partials      201      201           

Flag	Coverage Δ
javascript	72.51% <0.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (ø)
...c/views/CRUD/data/database/DatabaseModal/styles.ts	97.46% <0.00%> (+1.46%)	⬆️
...c/views/CRUD/data/database/DatabaseModal/index.tsx	59.29% <0.00%> (+2.68%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67e3730...9e9c8c8. Read the comment docs.

[pkdotson]

/testenv up

[suddjian]

@pkdotson in this case I don't think a testenv will be able to fully verify the PR, see test plan

[github-actions]

@pkdotson Ephemeral environment spinning up at http://34.222.39.207:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[betodealmeida]

LGTM... I really need to push for deprecating local storage and have the backend persistence always on.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.