Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update pull request template #14723

Merged
merged 2 commits into from
May 20, 2021
Merged

Conversation

suddjian
Copy link
Member

SUMMARY

Just a minor change to make the PR template a little clearer

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #14723 (b79dc1a) into master (4160e45) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14723   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files         959      959           
  Lines       48696    48696           
  Branches     5739     5739           
=======================================
  Hits        37763    37763           
  Misses      10732    10732           
  Partials      201      201           
Flag Coverage Δ
hive 81.10% <ø> (ø)
javascript 72.53% <ø> (ø)
mysql 81.38% <ø> (ø)
postgres 81.40% <ø> (ø)
presto 81.09% <ø> (ø)
python 81.92% <ø> (ø)
sqlite 81.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4160e45...b79dc1a. Read the comment docs.

@suddjian suddjian changed the title Update PULL_REQUEST_TEMPLATE.md chore: Update pull request template May 19, 2021
@suddjian suddjian requested a review from junlincc May 20, 2021 18:16
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

product sign-off ✅

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@junlincc junlincc added the need:merge The PR is ready to be merged label May 20, 2021
@pkdotson pkdotson merged commit 32622c5 into master May 20, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
@mistercrunch mistercrunch deleted the suddjian-pr-template-update branch March 26, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants