fix(docker): superset permissions and firefox config #14736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #14736 +/- ##
==========================================
- Coverage 77.54% 77.31% -0.24%
==========================================
Files 959 959
Lines 48696 48696
Branches 5743 5743
==========================================
- Hits 37762 37647 -115
- Misses 10733 10848 +115
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
reviewed
May 20, 2021
Comment on lines
-87
to
+88
| RUN useradd --user-group --no-create-home --no-log-init --shell /bin/bash superset \ | ||
| && mkdir -p ${SUPERSET_HOME} ${PYTHONPATH} \ | ||
| RUN useradd --user-group -d ${SUPERSET_HOME} --no-log-init --shell /bin/bash superset \ | ||
| && mkdir -p ${PYTHONPATH} \ |
docker/docker-bootstrap.sh
Outdated
| @@ -41,7 +41,7 @@ if [[ "${1}" == "worker" ]]; then | |||
| celery worker --app=superset.tasks.celery_app:app -Ofair -l INFO | |||
| elif [[ "${1}" == "beat" ]]; then | |||
| echo "Starting Celery beat..." | |||
| celery beat --app=superset.tasks.celery_app:app --pidfile /tmp/celerybeat.pid -l INFO | |||
| celery beat --app=superset.tasks.celery_app:app --pidfile /tmp/celerybeat.pid -l INFO -s /app/superset_home/celerybeat-schedule | |||
There was a problem hiding this comment.
Should we pick the path to /app/superset_home from ${SUPERSET_HOME}?
willbarrett
approved these changes
May 25, 2021
This was referenced May 28, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* fix(docker): superset permissions and firefox config * fix lint * user SUPERSET_HOME ENV on bootstrap script
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* fix(docker): superset permissions and firefox config * fix lint * user SUPERSET_HOME ENV on bootstrap script
john-bodley
reviewed
Jun 9, 2022
| "--high-dpi-support=2.0", | ||
| "--headless", | ||
| ] | ||
| WEBDRIVER_OPTION_ARGS = ["--headless", "--marionette"] |
There was a problem hiding this comment.
@dpgaspar should this just be ["--headless"] given that the WEBDRIVER_TYPE is defaulted to firefox? Or is the comment now wrong.
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix(docker): superset permissions and firefox config * fix lint * user SUPERSET_HOME ENV on bootstrap script
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes/improves the following:
ADDITIONAL INFORMATION