Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extra table metadata for Google Sheets #14775

Merged
merged 2 commits into from
Jul 2, 2021

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented May 24, 2021

SUMMARY

This PR uses the new GET_METADATA function in shillelagh 0.7.0 to show extra metadata about spreadsheets in the metadata browser in SQL Lab, namely the Spreadsheet and Sheet (tab) titles.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

Screen Shot 2021-06-30 at 9 41 41 PM

TESTING INSTRUCTIONS

  1. Add a Google Sheets database connection with credentials.
  2. Go to SQL Lab, choose Google Sheets.
  3. Choose the "main" schema.
  4. The list of spreadsheets should show up as tables. Click one.
  5. The metadata should show up correctly.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida force-pushed the gsheets_metadata branch 2 times, most recently from 9b00466 to 24046a5 Compare May 24, 2021 16:59
@betodealmeida betodealmeida force-pushed the gsheets_metadata branch 2 times, most recently from 35a0828 to 64689be Compare July 1, 2021 04:39
@betodealmeida betodealmeida changed the title WIP feat: extra table metadata for Google Sheets Jul 1, 2021
@betodealmeida betodealmeida force-pushed the gsheets_metadata branch 2 times, most recently from ac63af1 to 0f68d39 Compare July 1, 2021 04:46
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 1, 2021
@betodealmeida betodealmeida marked this pull request as ready for review July 2, 2021 00:27
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 2, 2021
@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #14775 (a7d0c5a) into master (7f2f51b) will decrease coverage by 0.28%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14775      +/-   ##
==========================================
- Coverage   77.24%   76.96%   -0.29%     
==========================================
  Files         975      976       +1     
  Lines       50866    51238     +372     
  Branches     6740     6895     +155     
==========================================
+ Hits        39293    39433     +140     
- Misses      11357    11586     +229     
- Partials      216      219       +3     
Flag Coverage Δ
hive 81.35% <35.29%> (-0.03%) ⬇️
javascript 71.52% <57.14%> (-0.34%) ⬇️
mysql 81.62% <35.29%> (-0.03%) ⬇️
postgres 81.64% <35.29%> (-0.03%) ⬇️
presto ?
python 82.01% <35.29%> (-0.18%) ⬇️
sqlite 81.25% <35.29%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/SqlLab/reducers/getInitialState.js 50.00% <ø> (ø)
superset/db_engine_specs/gsheets.py 58.33% <35.29%> (-21.67%) ⬇️
...et-frontend/src/SqlLab/components/TableElement.tsx 88.75% <57.14%> (-3.25%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 47.86% <0.00%> (-27.46%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/styles.ts 86.11% <0.00%> (-11.15%) ⬇️
...RUD/data/database/DatabaseModal/SqlAlchemyForm.tsx 92.30% <0.00%> (-7.70%) ⬇️
superset/db_engine_specs/presto.py 84.42% <0.00%> (-5.90%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 48.23% <0.00%> (-4.58%) ⬇️
superset/db_engine_specs/bigquery.py 87.75% <0.00%> (-2.18%) ⬇️
superset/connectors/sqla/models.py 88.45% <0.00%> (-1.42%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f2f51b...a7d0c5a. Read the comment docs.

@betodealmeida betodealmeida merged commit cbc4aa8 into apache:master Jul 2, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* feat: GSheets extra table metadata

* Bump version
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* feat: GSheets extra table metadata

* Bump version
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* feat: GSheets extra table metadata

* Bump version
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants