Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Big Query API for POST w/ no parameters #14822

Merged
merged 3 commits into from
May 25, 2021
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 25, 2021

SUMMARY

Put in a quick fix to pull data from credentials_info key, and check for configuration_method instead of parameters.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #14822 (386259f) into master (dfe030b) will decrease coverage by 0.23%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14822      +/-   ##
==========================================
- Coverage   77.62%   77.38%   -0.24%     
==========================================
  Files         962      962              
  Lines       49172    49174       +2     
  Branches     6184     6184              
==========================================
- Hits        38169    38055     -114     
- Misses      10801    10917     +116     
  Partials      202      202              
Flag Coverage Δ
hive ?
javascript 72.44% <ø> (ø)
mysql 81.62% <69.23%> (-0.01%) ⬇️
postgres 81.65% <69.23%> (-0.01%) ⬇️
presto ?
python 81.73% <69.23%> (-0.45%) ⬇️
sqlite 81.26% <69.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/bigquery.py 90.15% <0.00%> (-0.69%) ⬇️
superset/databases/schemas.py 98.72% <81.81%> (+<0.01%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.53%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.08% <0.00%> (-1.67%) ⬇️
superset/db_engine_specs/base.py 87.90% <0.00%> (-0.41%) ⬇️
superset/models/core.py 89.70% <0.00%> (-0.27%) ⬇️
superset/utils/core.py 88.91% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe030b...386259f. Read the comment docs.

@betodealmeida betodealmeida self-requested a review May 25, 2021 20:07
@hughhhh hughhhh merged commit c728947 into master May 25, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* Update schemas.py

* Update bigquery.py

* Fix tests

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* Update schemas.py

* Update bigquery.py

* Fix tests

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
@rusackas rusackas deleted the hugh/bg-patch branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Update schemas.py

* Update bigquery.py

* Fix tests

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants