Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update frequently-asked-questions-page.mdx #14837

Merged
merged 4 commits into from Nov 21, 2021
Merged

docs: Update frequently-asked-questions-page.mdx #14837

merged 4 commits into from Nov 21, 2021

Conversation

kurtiswen
Copy link
Contributor

SUMMARY

refine answer for first question, added SQL Lab query description.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kurtiswen
Update frequently-asked-questions-page.mdx
4d7f76c 
refine answer for first question, added SQL Lab query description.
amitmiran137
amitmiran137 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitmiran137 amitmiran137 marked this pull request as draft June 29, 2021 08:44
@amitmiran137 amitmiran137 marked this pull request as ready for review June 29, 2021 08:45
@amitmiran137
Copy link
Member

@kurtiswen fix pre-commit issues, you can use:
tox -e pre-commit -- --all-files and fix any manual fixes that are needed

@villebro villebro closed this Nov 19, 2021
@villebro villebro reopened this Nov 19, 2021
@villebro villebro changed the title Update frequently-asked-questions-page.mdx docs: Update frequently-asked-questions-page.mdx Nov 19, 2021
@villebro villebro merged commit 19f1c40 into apache:master Nov 21, 2021
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
@kurtiswen @villebro @AAfghahi
docs: Update frequently-asked-questions-page.mdx (#14837)
bc46796 
* Update frequently-asked-questions-page.mdx

refine answer for first question, added SQL Lab query description.

* fix EOL lint

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@amitmiran137 amitmiran137 amitmiran137 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kurtiswen @amitmiran137 @villebro @mistercrunch