Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Full width tabs flaky behavior #14840

Merged
merged 1 commit into from
May 31, 2021
Merged

fix: Full width tabs flaky behavior #14840

merged 1 commit into from
May 31, 2021

Conversation

geido
Copy link
Member

@geido geido commented May 26, 2021

SUMMARY

Reverts a style change introduced by PR #14478 that was causing a conflict with the Antd on-the-fly width calculation of the tabs.

@pkdotson I could not see any obvious issue with removing your code. Please clarify if reverting might cause specific problems anywhere.

BEFORE

COVID.Vaccine.Da.1.mp4

AFTER

COVID.Vaccine.Da.mp4

TESTING INSTRUCTIONS

  1. Open a Dashboard and edit
  2. Zoom out 10%
  3. Make sure the tabs on the left are not showing a flaky behavior

ADDITIONAL INFORMATION

  • Has associated issue: Fixes [tab]flaky behavior in tab component #14763
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #14840 (3e100c7) into master (3224e75) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14840   +/-   ##
=======================================
  Coverage   77.62%   77.62%           
=======================================
  Files         963      963           
  Lines       49236    49236           
  Branches     6192     6192           
=======================================
  Hits        38217    38217           
  Misses      10819    10819           
  Partials      200      200           
Flag Coverage Δ
javascript 72.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Tabs/Tabs.tsx 96.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3224e75...3e100c7. Read the comment docs.

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://34.221.70.56:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I pulled the branch because the ephmereal env isn't working for me and I didn't see any tab issues. Thanks for the fix!

@junlincc junlincc added the bash! label May 28, 2021
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work! Thanks for fixing (as far as I can tell!)

@rusackas rusackas merged commit d86880d into apache:master May 31, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@suddjian suddjian moved this from Unassigned to Done in Community Usability Bash! 🐛🐞🕷 Jul 8, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[tab]flaky behavior in tab component
6 participants