-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Full width tabs flaky behavior #14840
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14840 +/- ##
=======================================
Coverage 77.62% 77.62%
=======================================
Files 963 963
Lines 49236 49236
Branches 6192 6192
=======================================
Hits 38217 38217
Misses 10819 10819
Partials 200 200
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@pkdotson Ephemeral environment spinning up at http://34.221.70.56:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I pulled the branch because the ephmereal env isn't working for me and I didn't see any tab issues. Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work! Thanks for fixing (as far as I can tell!)
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Reverts a style change introduced by PR #14478 that was causing a conflict with the Antd on-the-fly width calculation of the tabs.
@pkdotson I could not see any obvious issue with removing your code. Please clarify if reverting might cause specific problems anywhere.
BEFORE
COVID.Vaccine.Da.1.mp4
AFTER
COVID.Vaccine.Da.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION