feat(trino): add support for user impersonation

[rijojoseph07]

SUMMARY

When using authentication with trino, the current behavior is just to modify the URL to replace the username which will result in an unauthorized exception. This PR will fix this by updating the connection argument with the effective user.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Step 1: Setup database connection to trino with credentials in URL.
Step 2: Enable impersonation from Other option
Step 3 : Log in with a different user and run the query via SQL lab and you will see the principal user as admin and user as the logged-in user in trino UI.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #14843 (a0268dd) into master (6bdbd2b) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #14843      +/-   ##
==========================================
- Coverage   77.62%   77.51%   -0.11%     
==========================================
  Files         963      963              
  Lines       49237    49315      +78     
  Branches     6192     6226      +34     
==========================================
+ Hits        38218    38225       +7     
- Misses      10819    10889      +70     
- Partials      200      201       +1     

Flag	Coverage Δ
hive	81.36% <100.00%> (+0.04%)	⬆️
javascript	72.39% <ø> (-0.10%)	⬇️
mysql	81.64% <100.00%> (+0.04%)	⬆️
postgres	81.66% <100.00%> (+0.04%)	⬆️
presto	?
python	82.03% <100.00%> (-0.11%)	⬇️
sqlite	81.27% <100.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx	93.54% <ø> (ø)
superset/db_engine_specs/trino.py	94.73% <100.00%> (+1.40%)	⬆️
...d/src/dashboard/components/gridComponents/Tabs.jsx	76.31% <0.00%> (-11.06%)	⬇️
superset/db_engine_specs/presto.py	84.42% <0.00%> (-5.48%)	⬇️
...nd/src/explore/components/DataTablesPane/index.tsx	83.90% <0.00%> (-4.99%)	⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	69.16% <0.00%> (-3.48%)	⬇️
...nfigModal/FiltersConfigForm/getControlItemsMap.tsx	97.05% <0.00%> (-2.95%)	⬇️
.../src/explore/components/ControlPanelsContainer.tsx	79.16% <0.00%> (-1.69%)	⬇️
superset/connectors/sqla/models.py	88.33% <0.00%> (-1.43%)	⬇️
...src/dashboard/components/FiltersBadge/selectors.ts	75.70% <0.00%> (-1.23%)	⬇️
... and 27 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bdbd2b...a0268dd. Read the comment docs.

[dungdm93]

You should add Trino to superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx as well

[rijojoseph07]

You should add Trino to superset-frontend/src/views/CRUD/data/database/DatabaseModal.tsx as well

Thanks, @dungdm93

Looks like this is moved here : superset-frontend/src/views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx . Have updated the labels here.

[betodealmeida]

We want to do this only if "enable impersonation" is true, no? In that case it would be better to add it to modify_url_for_impersonation.

[rijojoseph07]

this is called only if impersonation is enabled

// from core.py

if self.impersonate_user:
            self.db_engine_spec.update_impersonation_config(
                connect_args, str(sqlalchemy_url), effective_username
            )

modify_url will work only if authentication is disabled - we will have to modify connection args to pass logged In user_name based on the underlying connector - for presto, its principal_username and for trino its user.

[betodealmeida]

Ah, good point, I missed that.

[betodealmeida]

This is awesome, excited to see Trino being more supported in Superset.

[villebro]

LGTM, thanks for the great improvement!