Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Align down icons on header #14846

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

On the top nav header, the down arrow icons were slightly too low - they should be aligned with the center of the + button across all of the icons. I adjusted the svg icons from top: 23 to top: 21.

BEFORE/AFTER SCREENSHOTS

BEFORE:

down-icons-before

AFTER:

down-icons-after

TESTING INSTRUCTIONS

  • Navigate to any Superset page and observe the properly-aligned down arrow svg icons in the top navbar.

ADDITIONAL INFORMATION

  • Has associated issue: Clubhouse Ticket
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #14846 (402f1c3) into master (e466066) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14846   +/-   ##
=======================================
  Coverage   77.61%   77.61%           
=======================================
  Files         963      963           
  Lines       49246    49248    +2     
  Branches     6197     6197           
=======================================
+ Hits        38224    38226    +2     
  Misses      10821    10821           
  Partials      201      201           
Flag Coverage Δ
javascript 72.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Menu/Menu.tsx 66.66% <100.00%> (+0.40%) ⬆️
...uperset-frontend/src/components/Menu/MenuRight.tsx 93.87% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e466066...402f1c3. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hughhhh hughhhh self-requested a review June 8, 2021 17:09
@hughhhh hughhhh merged commit 94c86c3 into apache:master Jun 8, 2021
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/center-navbar-arrows branch October 15, 2021 01:32
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants