fix: DatabaseConnection Modal Margin Bottom #14849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🏷️ 2021.21 |
Codecov Report
@@ Coverage Diff @@
## master #14849 +/- ##
=======================================
Coverage 77.61% 77.61%
=======================================
Files 963 963
Lines 49246 49246
Branches 6197 6197
=======================================
Hits 38224 38224
Misses 10821 10821
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
reviewed
May 26, 2021
| @@ -81,7 +81,6 @@ export const antDModalNoPaddingStyles = css` | |||
| .ant-modal-body { | |||
| padding-left: 0; | |||
| padding-right: 0; | |||
| margin-bottom: 110px; | |||
There was a problem hiding this comment.
I think we still want this margin just for the sqlalchemy view.
There was a problem hiding this comment.
just checking in, we are keeping this change or should i go back to 110px?
hughhhh
approved these changes
May 27, 2021
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 1, 2021
(cherry picked from commit 877201f)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The margin bottom for the modal form was too large. This PR fixers it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Go into Database, create a new database.
ADDITIONAL INFORMATION