fix: show error on invalid import #14851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The current import API needs to raise an error if the user tries to import and invalid file.
Since we check which files are valid, I added a simple test to all import APIs:
Which returns an error message with a 400 HTTP status code.
I also took the time to SIP-41-fy the endpoints, removing the
@safe
decorator so exceptions can bubble up to the error handlers. Since the exceptions that the command can raise all have the correct HTTP status codes, this will preserve the existing behavior.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Tested manually with an invalid import.
ADDITIONAL INFORMATION