Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leverage qs to create new tab #14855

Merged
merged 1 commit into from May 28, 2021
Merged

fix: leverage qs to create new tab #14855

merged 1 commit into from May 28, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 26, 2021

SUMMARY

Create a new tab when users use the navigation new SQL Lab Button.

https://www.loom.com/share/5dfa5b51ed4c4ba3863ddce3b991d7b1

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #14855 (b50a92d) into master (e466066) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14855      +/-   ##
==========================================
- Coverage   77.61%   77.61%   -0.01%     
==========================================
  Files         963      963              
  Lines       49246    49487     +241     
  Branches     6197     6319     +122     
==========================================
+ Hits        38224    38408     +184     
- Misses      10821    10876      +55     
- Partials      201      203       +2     
Flag Coverage Δ
hive 81.32% <ø> (ø)
javascript 72.49% <ø> (+<0.01%) ⬆️
mysql 81.59% <ø> (ø)
postgres 81.62% <ø> (ø)
presto 81.31% <ø> (+<0.01%) ⬆️
python 82.14% <ø> (+<0.01%) ⬆️
sqlite 81.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/components/Menu/MenuRight.tsx 93.75% <ø> (ø)
superset/db_engine_specs/presto.py 90.31% <0.00%> (+0.42%) ⬆️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 66.82% <0.00%> (+5.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e466066...b50a92d. Read the comment docs.

@hughhhh hughhhh added the need:merge The PR is ready to be merged label May 28, 2021
@betodealmeida betodealmeida merged commit 0eb34be into master May 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@rusackas rusackas deleted the hugh/new-sql-tab branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants