Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more timeout configuration on screenshots #14868

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 27, 2021

SUMMARY

Fixes error handling on screenshots and adds more configuration options around screenshots timeout

New configuration keys:
SCREENSHOT_SELENIUM_HEADSTART: in seconds
SCREENSHOT_SELENIUM_RETRIES: in seconds

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good - do we want to add tests for the additional options and error handling?

@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #14868 (fd97c34) into master (0e07a5c) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14868      +/-   ##
==========================================
- Coverage   77.64%   77.64%   -0.01%     
==========================================
  Files         966      966              
  Lines       49615    49616       +1     
  Branches     6311     6311              
==========================================
  Hits        38524    38524              
- Misses      10890    10891       +1     
  Partials      201      201              
Flag Coverage Δ
hive ?
mysql 81.70% <80.00%> (?)
postgres 81.73% <80.00%> (+0.06%) ⬆️
presto 81.41% <80.00%> (?)
python 81.99% <80.00%> (-0.01%) ⬇️
sqlite 81.34% <80.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/webdriver.py 78.08% <75.00%> (+24.02%) ⬆️
superset/config.py 91.15% <100.00%> (+0.06%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/utils/core.py 88.91% <0.00%> (-0.13%) ⬇️
superset/views/core.py 75.48% <0.00%> (+0.44%) ⬆️
superset/models/core.py 90.00% <0.00%> (+1.05%) ⬆️
superset/connectors/sqla/models.py 89.57% <0.00%> (+1.18%) ⬆️
superset/db_engine_specs/mysql.py 94.28% <0.00%> (+1.42%) ⬆️
superset/db_engine_specs/presto.py 89.89% <0.00%> (+5.47%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e07a5c...fd97c34. Read the comment docs.

@dpgaspar dpgaspar merged commit 4e998e6 into apache:master Jun 8, 2021
@dpgaspar dpgaspar deleted the danielgaspar/ch8960/investigate-selenium-timeout-errors branch June 8, 2021 14:33
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* feat: more timeout configuration on screenshots

* add tests
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* feat: more timeout configuration on screenshots

* add tests
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* feat: more timeout configuration on screenshots

* add tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants