-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more timeout configuration on screenshots #14868
feat: add more timeout configuration on screenshots #14868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good - do we want to add tests for the additional options and error handling?
Codecov Report
@@ Coverage Diff @@
## master #14868 +/- ##
==========================================
- Coverage 77.64% 77.64% -0.01%
==========================================
Files 966 966
Lines 49615 49616 +1
Branches 6311 6311
==========================================
Hits 38524 38524
- Misses 10890 10891 +1
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* feat: more timeout configuration on screenshots * add tests
* feat: more timeout configuration on screenshots * add tests
* feat: more timeout configuration on screenshots * add tests
SUMMARY
Fixes error handling on screenshots and adds more configuration options around screenshots timeout
New configuration keys:
SCREENSHOT_SELENIUM_HEADSTART
: in secondsSCREENSHOT_SELENIUM_RETRIES
: in secondsADDITIONAL INFORMATION