Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update CONTRIBUTING.md #14880

Merged
merged 1 commit into from Jun 28, 2021
Merged

chore: Update CONTRIBUTING.md #14880

merged 1 commit into from Jun 28, 2021

Conversation

Ibby-B
Copy link
Contributor

@Ibby-B Ibby-B commented May 27, 2021

SUMMARY

Added a description of the extra_filters chart parameter, usage ideas and links to source files.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Ibby-B
Update CONTRIBUTING.md
0b69b3d 
Description of the extra_filters chart parameter, usage ideas and links to source files.
michael-s-molina
michael-s-molina approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@amitmiran137 amitmiran137 reopened this Jun 28, 2021
@amitmiran137 amitmiran137 changed the title Update CONTRIBUTING.md chore: Update CONTRIBUTING.md Jun 28, 2021
@amitmiran137 amitmiran137 merged commit 18f3089 into apache:master Jun 28, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@Ibby-B
Update CONTRIBUTING.md (apache#14880)
832827d 
Description of the extra_filters chart parameter, usage ideas and links to source files.

Co-authored-by: Dirzel <78026187+Dirzel@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@Ibby-B
Update CONTRIBUTING.md (apache#14880)
fee03dc 
Description of the extra_filters chart parameter, usage ideas and links to source files.

Co-authored-by: Dirzel <78026187+Dirzel@users.noreply.github.com>
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@Ibby-B
Update CONTRIBUTING.md (apache#14880)
669ebc9 
Description of the extra_filters chart parameter, usage ideas and links to source files.

Co-authored-by: Dirzel <78026187+Dirzel@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ibby-B @michael-s-molina @mistercrunch @amitmiran137